Skip to content

Comments

remove docker-generate and docker-notation code#269

Merged
SteveLasker merged 2 commits intonotaryproject:mainfrom
chloeyin:cobra-cli
Jul 28, 2022
Merged

remove docker-generate and docker-notation code#269
SteveLasker merged 2 commits intonotaryproject:mainfrom
chloeyin:cobra-cli

Conversation

@chloeyin
Copy link
Contributor

@chloeyin chloeyin commented Jul 27, 2022

Signed-off-by: zaihaoyin zaihaoyin@microsoft.com

This PR removes docker-notation and docker-generate command as discussed in

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a step forward

zaihaoyin added 2 commits July 28, 2022 13:53
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #269 (4d01dd8) into main (20bb2ca) will increase coverage by 2.50%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   47.49%   50.00%   +2.50%     
==========================================
  Files          15       11       -4     
  Lines         419      344      -75     
==========================================
- Hits          199      172      -27     
+ Misses        212      164      -48     
  Partials        8        8              
Impacted Files Coverage Δ
internal/cmd/flags.go 54.54% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveLasker SteveLasker merged commit 433d02f into notaryproject:main Jul 28, 2022
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
* remove docker-generate and docker-notation code
* clean cicd file and makefile

Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove docker-generate and docker-notation code

5 participants