Merged
Conversation
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #274 +/- ##
===========================================
- Coverage 50.00% 29.37% -20.63%
===========================================
Files 11 27 +16
Lines 344 1685 +1341
===========================================
+ Hits 172 495 +323
- Misses 164 1176 +1012
- Partials 8 14 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
|
LGTM |
binbin-li
reviewed
Jul 29, 2022
Contributor
|
Left some tiny comments. Just wanna raise some questions out of scope.
|
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Contributor
|
lgtm overall |
Contributor
We are still figuring out a better way to test CLI. |
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zaihaoyin zaihaoyin@microsoft.com
This PR adds unit test for some cli commands, only to make sure the flags are parsed correctly.
This is the last PR of the whole series(#255).