Merged
Conversation
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
yizha1
requested review from
FeynmanZhou,
dtzar,
gokarnm,
iamsamirzon and
shizhMSFT
yizha1
added
cli
Signed-off-by: Yi Zha <zhayi@outlook.com>
FeynmanZhou
reviewed
Sep 20, 2022
FeynmanZhou
reviewed
Sep 20, 2022
FeynmanZhou
reviewed
Sep 20, 2022
FeynmanZhou
reviewed
Sep 21, 2022
FeynmanZhou
reviewed
Sep 21, 2022
FeynmanZhou
reviewed
Sep 21, 2022
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 30.62% 30.54% -0.08%
==========================================
Files 25 25
Lines 1610 1614 +4
==========================================
Hits 493 493
- Misses 1104 1108 +4
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gokarnm
requested changes
Sep 22, 2022
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
dtzar
approved these changes
Sep 26, 2022
shizhMSFT
reviewed
Sep 28, 2022
Signed-off-by: Yi Zha <zhayi@outlook.com>
shizhMSFT
requested changes
Sep 29, 2022
gokarnm
approved these changes
Sep 29, 2022
Contributor
gokarnm
left a comment
gokarnm
left a comment
There was a problem hiding this comment.
LGTM! Except for expiry duration which I think we should switch to an expiry date time instead.
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
shizhMSFT
reviewed
Sep 30, 2022
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Yi Zha <zhayi@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to create a new CLI spec for
notation signunder a new directory namedcommandline. Thenotation-cli.mdwill be updated later to provide a list ofnotationcommands and link each command to individual spec.