Skip to content

Comments

update: updated notation key command based on spec#416

Merged
shizhMSFT merged 25 commits intonotaryproject:mainfrom
patrickzheng200:key
Oct 31, 2022
Merged

update: updated notation key command based on spec#416
shizhMSFT merged 25 commits intonotaryproject:mainfrom
patrickzheng200:key

Conversation

@patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Oct 26, 2022

This PR updates notation key command based on the key_spec.

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #416 (0766666) into main (a41b377) will increase coverage by 0.24%.
The diff coverage is 34.61%.

❗ Current head 0766666 differs from pull request most recent head 6f3420b. Consider uploading reports for the commit 6f3420b to get more accurate results

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   33.91%   34.16%   +0.24%     
==========================================
  Files          21       21              
  Lines        1138     1118      -20     
==========================================
- Hits          386      382       -4     
+ Misses        744      727      -17     
- Partials        8        9       +1     
Impacted Files Coverage Δ
cmd/notation/key.go 23.88% <34.61%> (+0.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yizha1 yizha1 added this to the beta-1 milestone Oct 26, 2022
@yizha1 yizha1 linked an issue Oct 26, 2022 that may be closed by this pull request
@yizha1 yizha1 requested review from a team, priteshbandi, rgnote and shizhMSFT October 26, 2022 06:13
Patrick Zheng added 2 commits October 26, 2022 14:21
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 requested a review from a team October 27, 2022 05:31
@yizha1 yizha1 removed this from the beta-1 milestone Oct 27, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 2 commits October 29, 2022 20:27
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@shizhMSFT shizhMSFT closed this Oct 31, 2022
@shizhMSFT shizhMSFT reopened this Oct 31, 2022
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Patrick Zheng added 2 commits October 31, 2022 14:41
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2992190 into notaryproject:main Oct 31, 2022
@patrickzheng200 patrickzheng200 deleted the key branch October 31, 2022 06:47
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
This PR updates notation key command based on the
[key_spec](https://github.com/notaryproject/notation/blob/main/specs/commandline/key.md).

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
This PR updates notation key command based on the
[key_spec](https://github.com/notaryproject/notation/blob/main/specs/commandline/key.md).

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implementing key command

6 participants