update: updated notation sign command based on spec#417
Merged
shizhMSFT merged 32 commits intonotaryproject:mainfrom Oct 31, 2022
Merged
update: updated notation sign command based on spec#417shizhMSFT merged 32 commits intonotaryproject:mainfrom
shizhMSFT merged 32 commits intonotaryproject:mainfrom
Conversation
added 14 commits
October 12, 2022 11:02
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage ? 34.11%
=======================================
Files ? 21
Lines ? 1061
Branches ? 0
=======================================
Hits ? 362
Misses ? 690
Partials ? 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
reviewed
Oct 26, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 2 commits
October 29, 2022 20:27
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 2 commits
October 31, 2022 14:17
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Oct 31, 2022
added 3 commits
October 31, 2022 14:46
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Oct 31, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
This PR updates notation sign command based on the [sign_spec](https://github.com/notaryproject/notation/blob/main/specs/commandline/sign.md). Tested with `notation certificate generate-test` and `notation sign` on ACR. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
This PR updates notation sign command based on the [sign_spec](https://github.com/notaryproject/notation/blob/main/specs/commandline/sign.md). Tested with `notation certificate generate-test` and `notation sign` on ACR. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates notation sign command based on the sign_spec.
Tested with
notation certificate generate-testandnotation signon ACR.Signed-off-by: Patrick Zheng patrickzheng@microsoft.com