Skip to content

Comments

update: update notation CLI with notation-go refactoring#445

Merged
shizhMSFT merged 46 commits intonotaryproject:mainfrom
patrickzheng200:rc1
Nov 29, 2022
Merged

update: update notation CLI with notation-go refactoring#445
shizhMSFT merged 46 commits intonotaryproject:mainfrom
patrickzheng200:rc1

Conversation

@patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Nov 17, 2022

This PR updates notation CLI logic to use the refactored notation-go with oras-go v2.0.0-rc.5.

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Patrick Zheng added 28 commits October 12, 2022 11:02
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #445 (0e9db2b) into main (236efca) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   32.82%   32.48%   -0.35%     
==========================================
  Files          25       25              
  Lines        1237     1250      +13     
==========================================
  Hits          406      406              
- Misses        819      832      +13     
  Partials       12       12              
Impacted Files Coverage Δ
cmd/notation/cert/generateTest.go 16.66% <0.00%> (-1.26%) ⬇️
cmd/notation/cert/list.go 13.79% <0.00%> (ø)
cmd/notation/cert/show.go 30.76% <0.00%> (ø)
cmd/notation/key.go 24.75% <0.00%> (+0.24%) ⬆️
cmd/notation/list.go 23.28% <0.00%> (-0.66%) ⬇️
cmd/notation/manifest.go 0.00% <0.00%> (ø)
cmd/notation/plugin.go 0.00% <0.00%> (ø)
cmd/notation/registry.go 0.00% <0.00%> (ø)
cmd/notation/sign.go 45.45% <0.00%> (+8.22%) ⬆️
cmd/notation/verify.go 22.07% <0.00%> (-2.93%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Patrick Zheng added 2 commits November 18, 2022 09:28
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 changed the title update: update notation CLI with notation-go refactoring (Draft) update: update notation CLI with notation-go refactoring Nov 18, 2022
@yizha1 yizha1 added this to the RC-1 milestone Nov 18, 2022
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Patrick Zheng added 2 commits November 21, 2022 10:00
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
go mod should be updated after notation-go PRs merged.

Patrick Zheng added 8 commits November 22, 2022 16:01
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@shizhMSFT shizhMSFT merged commit 86287b5 into notaryproject:main Nov 29, 2022
@patrickzheng200 patrickzheng200 deleted the rc1 branch November 30, 2022 00:58
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
…ct#445)

This PR updates notation CLI logic to use the refactored notation-go
with oras-go v2.0.0-rc.5.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
…ct#445)

This PR updates notation CLI logic to use the refactored notation-go
with oras-go v2.0.0-rc.5.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Notation CLI supporting OCI reference type System vs User file/directory precedence

6 participants