Skip to content

Dont access value of default pointer if it is nil#541

Merged
priteshbandi merged 1 commit intonotaryproject:mainfrom
priteshbandi:main
Feb 8, 2023
Merged

Dont access value of default pointer if it is nil#541
priteshbandi merged 1 commit intonotaryproject:mainfrom
priteshbandi:main

Conversation

@priteshbandi
Copy link
Contributor

@priteshbandi priteshbandi commented Feb 8, 2023

Don't access value of default pointer if it is nil. This is actually a bug(unable to delete key if defualt key is not present) fix.

Signed-off-by: Pritesh Bandi pritesb@amazon.com

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 053f0f8 into notaryproject:main Feb 8, 2023
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Don't access value of default pointer if it is nil. This is actually a bug(unable to delete key if defualt key is not present) fix.

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Don't access value of default pointer if it is nil. This is actually a bug(unable to delete key if defualt key is not present) fix.

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments