Skip to content

Comments

doc: update building guide#563

Merged
priteshbandi merged 2 commits intonotaryproject:mainfrom
JeyJeyGao:fix/update_installation_guide
May 19, 2023
Merged

doc: update building guide#563
priteshbandi merged 2 commits intonotaryproject:mainfrom
JeyJeyGao:fix/update_installation_guide

Conversation

@JeyJeyGao
Copy link
Contributor

Resolves #562
Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao JeyJeyGao requested a review from shizhMSFT as a code owner February 20, 2023 02:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #563 (b298972) into main (2e56dd4) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   33.16%   33.16%           
=======================================
  Files          32       32           
  Lines        2014     2014           
=======================================
  Hits          668      668           
  Misses       1324     1324           
  Partials       22       22           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FeynmanZhou
FeynmanZhou previously approved these changes Feb 27, 2023
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Feb 27, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao force-pushed the fix/update_installation_guide branch from 5b1ebf5 to d548db0 Compare March 21, 2023 11:45
FeynmanZhou
FeynmanZhou previously approved these changes Apr 4, 2023
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit c55aab0 into notaryproject:main May 19, 2023
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Resolves notaryproject#562 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Resolves notaryproject#562 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to build Notation project from source

6 participants