Skip to content

Comments

chore: update account info for Patrick Zheng#672

Merged
shizhMSFT merged 1 commit intonotaryproject:mainfrom
yizha1:add_2hearts
May 23, 2023
Merged

chore: update account info for Patrick Zheng#672
shizhMSFT merged 1 commit intonotaryproject:mainfrom
yizha1:add_2hearts

Conversation

@yizha1
Copy link
Contributor

@yizha1 yizha1 commented May 18, 2023

Resolve notaryproject/.github#27

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #672 (b0a7809) into main (d850c3f) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   36.12%   36.12%           
=======================================
  Files          32       32           
  Lines        1982     1982           
=======================================
  Hits          716      716           
  Misses       1238     1238           
  Partials       28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 4ca40a8 into notaryproject:main May 23, 2023
@shizhMSFT
Copy link
Contributor

Merging this PR since there is a majority of votes (4 + 1) over 8 eligible maintainers.

@yizha1 yizha1 deleted the add_2hearts branch May 23, 2023 02:15
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

patrickzheng@microsoft.com github account relink

7 participants