Skip to content

Comments

fix: fixed global variable verifier#676

Merged
priteshbandi merged 1 commit intomainfrom
unknown repository
May 22, 2023
Merged

fix: fixed global variable verifier#676
priteshbandi merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented May 22, 2023

This PR quick fixed verifier in verify.go.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #676 (448401b) into main (c55aab0) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   61.37%   61.37%           
=======================================
  Files          42       42           
  Lines        2281     2281           
=======================================
  Hits         1400     1400           
  Misses        782      782           
  Partials       99       99           
Impacted Files Coverage Δ
cmd/notation/verify.go 87.87% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 58bde11 into notaryproject:main May 22, 2023
@ghost ghost deleted the globalVar branch May 22, 2023 23:51
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
This PR quick fixed `verifier` in verify.go.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
This PR quick fixed `verifier` in verify.go.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants