test: add e2e test cases for flag --insecure-registry#679
Merged
shizhMSFT merged 12 commits intonotaryproject:mainfrom May 25, 2023
Merged
test: add e2e test cases for flag --insecure-registry#679shizhMSFT merged 12 commits intonotaryproject:mainfrom
--insecure-registry#679shizhMSFT merged 12 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
requested review from
NiazFK,
SteveLasker,
gokarnm,
justincormack,
priteshbandi,
rgnote and
shizhMSFT
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 61.35% 64.91% +3.55%
==========================================
Files 42 40 -2
Lines 2280 2183 -97
==========================================
+ Hits 1399 1417 +18
+ Misses 782 651 -131
- Partials 99 115 +16 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
changed the title
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
changed the title
--insecure-registry
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
reviewed
May 24, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
reviewed
May 25, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
6 tasks
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
…t#679) Feature: - add E2E testing TLS support for Github Action environment Test: - added `--insecure-registry` test for sign, verify, inspect, list > **Note** `login` command E2E test cases are not included in the PR because it needs to setup credential store in Github Action and should be done in another PR. Added an issue to track it notaryproject#680 Resolves notaryproject#633 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
…t#679) Feature: - add E2E testing TLS support for Github Action environment Test: - added `--insecure-registry` test for sign, verify, inspect, list > **Note** `login` command E2E test cases are not included in the PR because it needs to setup credential store in Github Action and should be done in another PR. Added an issue to track it notaryproject#680 Resolves notaryproject#633 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature:
Test:
--insecure-registrytest for sign, verify, inspect, listResolves #633
Signed-off-by: Junjie Gao junjiegao@microsoft.com