Skip to content

Comments

fix(test): E2E test cases for OCI layout#692

Merged
6 commits merged intonotaryproject:mainfrom
JeyJeyGao:fix/e2e_local_test
Jun 5, 2023
Merged

fix(test): E2E test cases for OCI layout#692
6 commits merged intonotaryproject:mainfrom
JeyJeyGao:fix/e2e_local_test

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented May 26, 2023 •
edited
Loading

Feat:

  • add E2E test framework oci layout support: generate isolated oci layout dynamically for each test case

Fix:

  • update oci layout test to use isolated oci layout (previsouly the oci layout is shared by multiple test cases)
  • the assertion target for TLS and --insecure-registry test cases

Test:

  • added new test cases for notation list --oci-layout

Resolves #693
Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao JeyJeyGao requested a review from a user May 26, 2023 07:23
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023 •
edited
Loading

Codecov Report

Merging #692 (e2347cd) into main (ebfb9ef) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
+ Coverage   63.81%   63.95%   +0.13%     
==========================================
  Files          40       40              
  Lines        2222     2222              
==========================================
+ Hits         1418     1421       +3     
+ Misses        682      680       -2     
+ Partials      122      121       -1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeyJeyGao JeyJeyGao changed the title fix: E2E test cases for OCI layout fix(test): E2E test cases for OCI layout May 26, 2023
ghost
ghost reviewed May 29, 2023
View reviewed changes
ghost
ghost reviewed May 29, 2023
View reviewed changes
ghost
ghost reviewed May 30, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that testdata are still in oci artifact manifest type. We'd better update them to oci image manifest? Otherwise, LGTM.

@JeyJeyGao
Copy link
Contributor Author

JeyJeyGao commented May 30, 2023

I notice that testdata are still in oci artifact manifest type. We'd better update them to oci image manifest? Otherwise, LGTM.

This PR is for fixing oci layout. #668 will be done in another PR.

ghost
ghost previously approved these changes May 30, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

JeyJeyGao added 6 commits June 2, 2023 16:28
@JeyJeyGao
fix: E2E test cases for OCI layout
a7a7b10 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update code
b2c1a4a 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update test framework
b7d65b0 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: added oci-layout test for list command
80dadcc 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comment
84aa94d 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comment
e2347cd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao dismissed stale reviews from priteshbandi, shizhMSFT, and ghost via e2347cd June 2, 2023 08:29
@JeyJeyGao JeyJeyGao force-pushed the fix/e2e_local_test branch from 77d2d0b to e2347cd Compare June 2, 2023 08:29
priteshbandi
priteshbandi approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi requested review from a user and shizhMSFT June 2, 2023 17:54
ghost
ghost approved these changes Jun 5, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit e090aa9 into notaryproject:main Jun 5, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
Merged
6 tasks
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
@JeyJeyGao @7h3-3mp7y-m4n
fix(test): E2E test cases for OCI layout (notaryproject#692)
aa00c0c
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
@JeyJeyGao @FeynmanZhou
fix(test): E2E test cases for OCI layout (notaryproject#692)
31e80f0
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OCI layout E2E test cases issue

4 participants

@JeyJeyGao @codecov-commenter @priteshbandi @shizhMSFT