Merged
Conversation
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
This was referenced Aug 27, 2021
Closed
juliusl
approved these changes
Aug 28, 2021
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
nate-double-u
left a comment
nate-double-u
left a comment
There was a problem hiding this comment.
I've added some comments inline.
gokarnm
reviewed
Sep 2, 2021
gokarnm
reviewed
Sep 2, 2021
gokarnm
reviewed
Sep 2, 2021
Merged
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Contributor
Author
|
PR feedback addressed. Please review latest updates. As #83 gets merged, and we start automating builds from main, I'll update the release location |
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Contributor
Author
|
👀 @notaryproject/notation-maintainers this is ready for review with https://github.com/shizhMSFT/notation/releases/tag/v0.5.2 |
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
gokarnm
reviewed
Sep 13, 2021
| ``` | ||
| - Sign the container image | ||
| ```bash | ||
| notation sign $IMAGE |
Contributor
There was a problem hiding this comment.
I'd prefer being explicit about the key being used and not using a default, we can address that later.
Contributor
Author
There was a problem hiding this comment.
We did want to enable the simple/default scenarios but appreciate the concern.
@gokarnm, can you open an issue for this?
Co-authored-by: Milind Gokarn <milind81@gmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
…into sample-hello-world Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
SteveLasker
force-pushed
the
sample-hello-world
branch
from
f74ec9f to
21e7981
Compare
…into sample-hello-world Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Merged
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
…into sample-hello-world
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
* Notary v2 prototye process Signed-off-by: Steve Lasker <stevelasker@hotmail.com> * Notary v2 prototye process Signed-off-by: Steve Lasker <stevelasker@hotmail.com> * Notary v2 prototye process updates Signed-off-by: Steve Lasker <stevelasker@hotmail.com> * Rev of sketch, w/oci-index v3-index.config Signed-off-by: Steve Lasker <stevelasker@hotmail.com> * Hello world of notation Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Add notation cli, updating from prototype-2 Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Add notation cli, updating from prototype-2 Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Add notation cli, updating from prototype-2 Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Incorporate feedback Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Incorporate feedback Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Update demo script to reflect latest CLI build Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Incorporate PR feedback Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * PR Feedback Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Updates with 0.5.2 alpha release Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Add stubs for sbom and signature policy Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Update hello-signing.md Co-authored-by: Milind Gokarn <milind81@gmail.com> * Add stubs for sbom and signature policy Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> * Remvoing TBD files Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> Co-authored-by: Steve Lasker <stevelasker@hotmail.com> Co-authored-by: Milind Gokarn <milind81@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the target commands, lifting the prototype-2 efforts to the nearly RC state of the artifacts-spec
Note: these commands don't work, yet. This is the target for what will work.
Please iterate any feedback here and we can incorporate into the work to support these commands.