doc: update readme.md for the Notary Project#263
Merged
yizha1 merged 10 commits intonotaryproject:mainfrom Aug 3, 2023
Merged
Conversation
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
requested review from
NiazFK,
SteveLasker,
gokarnm,
justincormack,
priteshbandi,
shizhMSFT,
toddysm and
vaninrao10
as code owners
This was referenced Jun 10, 2023
Closed
Closed
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Contributor
Author
|
NOTE: This PR will be amended later based on the Notary Project readme addressed by PR notaryproject/.github#32 |
Closed
TheFoxAtWork
left a comment
TheFoxAtWork
left a comment
There was a problem hiding this comment.
Further clarity is still needed but this is an improvement thank you!
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Contributor
Author
|
@TheFoxAtWork @priteshbandi @SteveLasker @justincormack @NiazFK @toddysm @FeynmanZhou @shizhMSFT @vaninrao10 @gokarnm @iamsamirzon I updated this PR per notaryproject/.github#35, please take a look. |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
shizhMSFT
reviewed
Jul 31, 2023
Signed-off-by: Yi Zha <yizha1@microsoft.com>
ghost
reviewed
Aug 1, 2023
shizhMSFT
previously approved these changes
Aug 1, 2023
gokarnm
reviewed
Aug 1, 2023
15 tasks
Signed-off-by: Yi Zha <yizha1@microsoft.com>
|
LGTM but IAMNAM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates:
Note: The folder structure in this PR reflected the current structure. Any changes on folder structure proposed in notaryproject/.github#48, are not in the scope of this PR
Other PRs related to removing Notary v2 reference for this repository:
Signed-off-by: Yi Zha yizha1@microsoft.com