fix(doc): add plugin output size limitation#320
Merged
yizha1 merged 4 commits intonotaryproject:mainfrom Jan 8, 2025
Merged
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
requested review from
NiazFK,
gokarnm,
priteshbandi,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
shizhMSFT
reviewed
Dec 2, 2024
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT
reviewed
Dec 3, 2024
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
added a commit
to notaryproject/notation-go
that referenced
this pull request
Dec 13, 2024
Fix: - set the plugin output limit for STDOUT and STDERR to be 10MiB Test: - when the plugin output size exceeds 64MiB, the output pipe breaks, and the plugin process outputs an error to STDERR Spec changes: notaryproject/specifications#320 Resolves #187 Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation PR: notaryproject/notation-go#484
Resolves notaryproject/notation-go#187