Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

Adding support for AWS IAM role credentials #128

Closed
andreaswittig wants to merge 1 commit into from
Closed

Adding support for AWS IAM role credentials #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/server/store/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { StoreS3 } from './providers/s3'

export function createStore() {
return new StoreS3({
accessKey: getEnv('STORE_ACCESS_KEY', undefined, true),
secretKey: getEnv('STORE_SECRET_KEY', undefined, true),
accessKey: getEnv('STORE_ACCESS_KEY'),
secretKey: getEnv('STORE_SECRET_KEY'),
Comment on lines +6 to +7
Copy link
Copy Markdown
Member

@tecc tecc Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses the old config system, which is the main reason why this cannot be merged yet.

endPoint: getEnv('STORE_END_POINT'),
bucket: getEnv('STORE_BUCKET', 'notea'),
region: getEnv('STORE_REGION', 'us-east-1'),
Expand Down
7 changes: 5 additions & 2 deletions libs/server/store/providers/s3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,14 @@ export class StoreS3 extends StoreProvider {
forcePathStyle: config.pathStyle,
region: config.region,
endpoint: config.endPoint,
credentials: {
credentials: ((config.accessKey && config.secretKey) ? {
accessKeyId: config.accessKey,
secretAccessKey: config.secretKey,
},
}: undefined),
})
if (!config.accessKey || !config.secretKey) {
console.log('[Notea] Environment variables STORE_ACCESS_KEY or STORE_SECRET_KEY is missing. Trying to use IAM role credentials instead ...')
}
this.config = config
}

Expand Down