Check if argument is a coroutine function before checking argument.func#40
Open
EvanKrall wants to merge 2 commits intonotion:masterfrom
Open
Check if argument is a coroutine function before checking argument.func#40EvanKrall wants to merge 2 commits intonotion:masterfrom
EvanKrall wants to merge 2 commits intonotion:masterfrom
Conversation
Author
|
I added tests and a tox configuration for running them (just install and run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kept running into issues with asynctest.CoroutineMock and a_sync.block():
This is because CoroutineMock returns a MagicMock for any undefined attribute access:
Since
to_blockingcurrently checksasync_func.funcfirst (which is not a coroutine function), it treats the CoroutineMock like a sync function, even though: