Feat. image block #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myjeong19
added
enhancement
packages/react-notion-custom/src/lib/components/image/image-viewer-tools.tsx
Outdated
Show resolved
Hide resolved
| hint={`${currentImageIndex + 2} of ${imageLength} `} | ||
| disabled={!hasNext} | ||
| > | ||
| <motion.button |
Collaborator
There was a problem hiding this comment.
p2: I think motion.button is not neccessary. you can use just button
|
|
||
| <div className="notion-image-viewer-scaler"> | ||
| <Tooltip content="Zoom out" hint="-"> | ||
| <motion.button |
Collaborator
There was a problem hiding this comment.
p2: I think motion.button is not neccessary. you can use just button
| <span>%</span> | ||
| </div> | ||
| ) : ( | ||
| <motion.button |
Collaborator
There was a problem hiding this comment.
p2: I think motion.button is not neccessary. you can use just button
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Here is reference: #25
support 'custom your created image' block
-> add custom solution for rendering 'image'
Review point
To reproduce
Screenshot
E1.84.92.E1.85.AA.E1.84.86.E1.85.A7.E1.86.AB.20.E1.84.80.E1.85.B5.E1.84.85.E1.85.A9.E1.86.A8.202024-10-02.20.E1.84.8B.E1.85.A9.E1.84.8C.E1.85.A5.E1.86.AB.201.mp4
Review Guide
Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.