Skip to content

Handle another error code when concurrently creating the migrations history table #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Sep 27, 2024
Merged

Handle another error code when concurrently creating the migrations history table #3301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/EFCore.PG/Migrations/Internal/NpgsqlHistoryRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ bool IHistoryRepository.CreateIfNotExists()
GetCreateIfNotExistsCommands(), Dependencies.Connection, new MigrationExecutionState(), commitTransaction: true)
!= 0;
}
catch (PostgresException e) when (e.SqlState is "23505" or "42P07")
catch (PostgresException e) when (e.SqlState is PostgresErrorCodes.UniqueViolation
or PostgresErrorCodes.DuplicateTable
or PostgresErrorCodes.DuplicateObject)
{
return false;
}
Expand All @@ -116,7 +118,9 @@ async Task<bool> IHistoryRepository.CreateIfNotExistsAsync(CancellationToken can
cancellationToken: cancellationToken).ConfigureAwait(false))
!= 0;
}
catch (PostgresException e) when (e.SqlState is "23505" or "42P07")
catch (PostgresException e) when (e.SqlState is PostgresErrorCodes.UniqueViolation
or PostgresErrorCodes.DuplicateTable
or PostgresErrorCodes.DuplicateObject)
{
return false;
}
Expand Down Expand Up @@ -192,7 +196,7 @@ public override IReadOnlyList<HistoryRow> GetAppliedMigrations()
{
return base.GetAppliedMigrations();
}
catch (PostgresException e) when (e.SqlState is "3D000" or "42P01")
catch (PostgresException e) when (e.SqlState is PostgresErrorCodes.InvalidCatalogName or PostgresErrorCodes.UndefinedTable)
{
return [];
}
Expand All @@ -210,7 +214,7 @@ public override async Task<IReadOnlyList<HistoryRow>> GetAppliedMigrationsAsync(
{
return await base.GetAppliedMigrationsAsync(cancellationToken).ConfigureAwait(false);
}
catch (PostgresException e) when (e.SqlState is "3D000" or "42P01")
catch (PostgresException e) when (e.SqlState is PostgresErrorCodes.InvalidCatalogName or PostgresErrorCodes.UndefinedTable)
{
return [];
}
Expand Down