Skip to content

Bump dependencies #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Oct 13, 2024
Merged

Bump dependencies #3316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
pull_request:

env:
dotnet_sdk_version: '9.0.100-rc.1.24452.12'
dotnet_sdk_version: '9.0.100-rc.2.24474.11'
postgis_version: 3
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ on:
- cron: '30 22 * * 6'

env:
dotnet_sdk_version: '9.0.100-rc.1.24452.12'
dotnet_sdk_version: '9.0.100-rc.2.24474.11'

jobs:
analyze:
Expand Down
10 changes: 3 additions & 7 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project>
<PropertyGroup>
<EFCoreVersion>[9.0.0-rc.2.24460.3]</EFCoreVersion>
<MicrosoftExtensionsVersion>9.0.0-rc.2.24456.9</MicrosoftExtensionsVersion>
<NpgsqlVersion>8.0.4</NpgsqlVersion>
<EFCoreVersion>[9.0.0-rc.2.24474.1]</EFCoreVersion>
Copy link

@weitzhandler weitzhandler Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is EF Core version defined as an exact version?
I'm trying to upgrade to .NET 9 and am facing issues because it wants this exact version of EF to be installed.

Suggested change
<EFCoreVersion>[9.0.0-rc.2.24474.1]</EFCoreVersion>
<EFCoreVersion>9.0.0-rc.2.24474.1</EFCoreVersion>

Copy link
Member Author

@roji roji Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are frequently breaking changes between previews, and mixing preview versions is generally untested. Since EFCore.PG previews are frequently a bit delayed compared to the EF previews, people very frequently try to mix them together and open issues. I then have to close those issues and tell people to wait for the EFCore.PG preview version that corresponds to the EF one.

For the actual released version, an exact version match isn't required - it's OK to mix different patch versions from EFCore.PG and EF (but major version mixing still isn't allowed).

<MicrosoftExtensionsVersion>9.0.0-rc.2.24473.5</MicrosoftExtensionsVersion>
<NpgsqlVersion>8.0.5</NpgsqlVersion>
</PropertyGroup>

<ItemGroup>
Expand All @@ -21,10 +21,6 @@
<PackageVersion Include="Npgsql.NetTopologySuite" Version="$(NpgsqlVersion)" />
<PackageVersion Include="Npgsql.DependencyInjection" Version="$(NpgsqlVersion)" />

<!-- Workaround for unsecure dependencies in EF -->
<PackageVersion Include="System.Formats.Asn1" Version="8.0.1" />
<PackageVersion Include="System.Text.Json" Version="8.0.4" />

<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageVersion Include="xunit" Version="2.9.0" />
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "9.0.100-rc.1.24452.12",
"version": "9.0.100-rc.2.24474.11",
"rollForward": "latestMajor",
"allowPrerelease": true
}
Expand Down
4 changes: 0 additions & 4 deletions test/EFCore.PG.FunctionalTests/EFCore.PG.FunctionalTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
<PackageReference Include="Microsoft.Extensions.Configuration.Json" />
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" />

<!-- Workaround for unsecure dependency on EF.Specification.Tests -->
<PackageReference Include="System.Formats.Asn1" />
<PackageReference Include="System.Text.Json" />

<!-- Needed to override xunit dependencies from EFCore projects on versions which aren't available on nuget.org -->
<PackageReference Include="xunit.assert" />
<PackageReference Include="xunit.core" />
Expand Down
16 changes: 16 additions & 0 deletions test/EFCore.PG.FunctionalTests/Query/PrimitiveCollectionsQueryNpgsqlTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,22 @@ WHERE cardinality(@__ints_0 || p."Ints") = 2
""");
}

public override async Task Parameter_collection_with_type_inference_for_JsonScalarExpression(bool async)
{
await base.Parameter_collection_with_type_inference_for_JsonScalarExpression(async);

AssertSql(
"""
@__values_0={ 'one', 'two' } (DbType = Object)

SELECT CASE
WHEN p."Id" <> 0 THEN @__values_0[p."Int" % 2 + 1]
ELSE 'foo'
END
FROM "PrimitiveCollectionsEntity" AS p
""");
}

public override async Task Column_collection_Union_parameter_collection(bool async)
{
await base.Column_collection_Union_parameter_collection(async);
Expand Down