Sync to EF 10.0.0-rc.2.25431.101 #3607
Conversation
| @complex_type_p_AddressLine1='New AddressLine1' | ||
| @complex_type_p_AddressLine2='New AddressLine2' | ||
| @complex_type_p_Tags={ 'new_tag1', 'new_tag2' } (DbType = Object) | ||
| @complex_type_p_Tags={ 'new_tag1' |
There was a problem hiding this comment.
@cincuranet see this change after syncing to latest upstream EF; this is most likely because of dotnet/efcore#36594. I think we should improve the logic slightly.
There was a problem hiding this comment.
The logic there, sadly, is inherently broken and can't be fixed without redoing the whole parameter processing.
There was a problem hiding this comment.
Well, couldn't we e.g. track parentheses characters in the logic you added ('{', '(', '[') and ignore commas when they're inside?
There was a problem hiding this comment.
(for that matter, we should also ignore commas within quotes if we're not already doing so)
There was a problem hiding this comment.
No, because single quotes are not escaped. I.e. @complex_type_p_AddressLine1='foo'bar'. Although we can "see" that foo'bar is the value, parsing the whole string with parameters is not reliable. We need to change it from having single string without escaping on input to either add escaping, or better pass a list.
2 participants
No description provided.