Skip to content

Add type-casts for SQL literals in list mapping #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austindrenski merged 1 commit into from
Jul 29, 2018
Merged

Add type-casts for SQL literals in list mapping #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/EFCore.PG/Storage/Internal/Mapping/NpgsqlListTypeMapping.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ protected override string GenerateNonNullSqlLiteral(object value)
sb.Append(ElementMapping.GenerateSqlLiteral(list[i]));
}

sb.Append(']');
sb.Append("]::");
sb.Append(ElementMapping.StoreType);
sb.Append("[]");
return sb.ToString();
}

Expand Down Expand Up @@ -143,7 +145,7 @@ static bool Compare(List<TElem> a, List<TElem> b, ValueComparer<TElem> elementCo

static List<TElem> Snapshot(List<TElem> source, ValueComparer<TElem> elementComparer)
{
if (source is null)
if (source == null)
return null;

var snapshot = new List<TElem>(source.Count);
Expand Down Expand Up @@ -194,7 +196,7 @@ static bool Compare(List<TElem> a, List<TElem> b)

static List<TElem> DoSnapshot(List<TElem> source)
{
if (source is null)
if (source == null)
return null;

var snapshot = new List<TElem>(source.Count);
Expand Down Expand Up @@ -243,7 +245,7 @@ static bool Compare(List<TElem> a, List<TElem> b)

static List<TElem> DoSnapshot(List<TElem> source)
{
if (source is null)
if (source == null)
return null;

var snapshot = new List<TElem>(source.Count);
Expand Down