This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Install bins properly when global root is a link #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
approved these changes
Feb 1, 2021
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
👍 confirmed bins go in the right spot with a symlinked root
Also fixes up a few other places where we were checking isRoot and should have been checking isProjectRoot. Fix: nodejs/build#2525 PR-URL: #217 Credit: @isaacs Close: #217 Reviewed-by: @nlf
isaacs
force-pushed
the
isaacs/link-root-global-put-bins-in-the-right-place
branch
from
c7e6733 to
2fc1525
Compare
wraithgar
deleted the
isaacs/link-root-global-put-bins-in-the-right-place
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install bins properly when global root is a link
Also fixes up a few other places where we were checking isRoot and
should have been checking isProjectRoot.
Fix: nodejs/build#2525