-
Notifications
You must be signed in to change notification settings - Fork 4k
npm doctor improvements #4495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
npm doctor improvements #4495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wraithgar
commented
Mar 3, 2022
- chore: mocknpm improvements
- chore: rewrite doctor tests
- fix(doctor): don't retry ping
- fix(doctor): allow for missing local bin and node_modules
da39e80 to
113c824
Compare
Member
Author
|
Converting to draft till the windows tests are fixed, and the mock globals stuff is implemented |
Contributor
|
no statistically significant performance changes detected timing results
|
make tests pass in prefixDir instead of testdir allow for cache and globalPrefix dirs
a515da3 to
b17e900
Compare
lukekarrys
approved these changes
Mar 8, 2022
3e81262 to
53a18f1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: next
These items should be addressed in the next release
Release 8.x
work is associated with a specific npm 8 release
semver:patch
semver patch level for changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.