Skip to content

fix: send options with grant/revoke requests #6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukekarrys merged 2 commits into from
Mar 8, 2023
Merged

fix: send options with grant/revoke requests #6211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
224476d
fix(access): Send options with grant/revoke requests
DavidTanner Mar 1, 2023
86741de
Added test to validate config
DavidTanner Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/commands/access.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,11 @@ class Access extends BaseCommand {
}

async #grant (permissions, scope, pkg) {
await libnpmaccess.setPermissions(scope, pkg, permissions)
await libnpmaccess.setPermissions(scope, pkg, permissions, this.npm.flatOptions)
}

async #revoke (scope, pkg) {
await libnpmaccess.removePermissions(scope, pkg)
await libnpmaccess.removePermissions(scope, pkg, this.npm.flatOptions)
}

async #listPackages (owner, pkg) {
Expand Down
16 changes: 14 additions & 2 deletions test/lib/commands/access.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,16 @@ t.test('grant', t => {
})

t.test('read-only', async t => {
const { npm } = await loadMockNpm(t)
const authToken = 'abcd1234'
const { npm } = await loadMockNpm(t, {
config: {
'//registry.npmjs.org/:_authToken': authToken,
},
})
const registry = new MockRegistry({
tap: t,
registry: npm.config.get('registry'),
authorization: authToken,
})
const permissions = 'read-only'
registry.setPermissions({ spec: '@npmcli/test-package', team: '@npm:test-team', permissions })
Expand All @@ -84,10 +90,16 @@ t.test('grant', t => {

t.test('revoke', t => {
t.test('success', async t => {
const { npm } = await loadMockNpm(t)
const authToken = 'abcd1234'
const { npm } = await loadMockNpm(t, {
config: {
'//registry.npmjs.org/:_authToken': authToken,
},
})
const registry = new MockRegistry({
tap: t,
registry: npm.config.get('registry'),
authorization: authToken,
})
registry.removePermissions({ spec: '@npmcli/test-package', team: '@npm:test-team' })
await npm.exec('access', ['revoke', '@npm:test-team', '@npmcli/test-package'])
Expand Down