fix: resolve override conflicts and apply correct versions #8089
Conversation
…D' for edge override set inconsistencies
| }) | ||
|
|
||
| t.equal(original.canReplaceWith(badReplacement), false, 'different overrides fails') | ||
| t.equal(original.canReplaceWith(equivalentReplacement), true, 'different overrides passes') |
There was a problem hiding this comment.
behavior change, equivalent can now override
|
@jdalton I'm feeling pretty good about this. Any chance you guys have some capacity to take a look? |
|
Thanks to everyone who worked on this! Fingers crossed we can do a cli release today and this should be included in it. |
wraithgar
changed the title
|
Thank you @owlstronaut! Will sync these up with our wrapper. I'll report back if anything funky happens. |
|
Hey @owlstronaut @wraithgar, |
11.2.0 -> #8074 |
|
Causes #8688 |
|
My overrides are not resolving after upgrading from "11.1.0" to "11.2.0" (and in any later version), no error, they are just ignored completely This seems to be a regression with workspaces only Reproduction: https://github.com/Tofandel/NPM-Workspace-override-bug/blob/main/package-lock.json#L564-L588 If I downgrade to 11.1.0 this resolves properly |
6 participants
This PR is to help get #7025 over the line. The community member did a great job the fixes in - this'll be an attempt to get it over the line
References
Related:
#7025 #5850