fix: save libc field to package-lock.json#9025
Merged
owlstronaut merged 1 commit intolatestfrom Feb 24, 2026
Merged
Conversation
owlstronaut
force-pushed
the
libc-fix
branch
from
671694b to
8a80a7b
Compare
wraithgar
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8514
The
libcfield was missing frompkgMetaKeysinshrinkwrap.js, so it was never written topackage-lock.json. This meant that on reinstall from a lockfile,checkPlatformcouldn't distinguish between glibc and musl variants of optional dependencies — both would be installed instead of just the one matching the current platform.The fix adds
libctopkgMetaKeysalongsideosandcpu. This is purely additive — packages withoutlibcare unaffected, and older npm versions will silently ignore the new field in lockfiles.