Conversation
wraithgar
force-pushed
the
gar/more-symbols
branch
from
38e7379 to
00c24d3
Compare
Member
Author
|
@manzoorwanijk Heads up we have decided to clean this file up now that we're looking more deeply at it lately. It may collide w/ other work you're doing but we'll try to handle merge conflicts as they come. |
Contributor
|
Thank you for the heads up. |
owlstronaut
reviewed
Mar 4, 2026
| const hash = crypto.createHash('shake256', { outputLength: 16 }) | ||
| .update(deps.join(',')) | ||
| .digest('base64') | ||
| // Node v14 doesn't support base64url |
Contributor
There was a problem hiding this comment.
Suggested change
| // Node v14 doesn't support base64url |
Can remove this now 😆
|
|
||
| const proxiedIdealTree = this.idealGraph | ||
| async createIsolatedTree () { | ||
| await this.makeIdealGraph(this.options) |
Contributor
There was a problem hiding this comment.
Suggested change
| await this.makeIdealGraph(this.options) | |
| await this.makeIdealGraph() |
Looks like the argument was removed
Comment on lines
188
to
207
| @@ -160,15 +206,19 @@ module.exports = cls => class IsolatedReifier extends cls { | |||
| } | |||
| } | |||
Contributor
There was a problem hiding this comment.
could these operations all be in the populateDeps guard so the work isn't done when populateDeps == false. Looks like the work is thrown away in that case
Member
Author
There was a problem hiding this comment.
Wow all of the edge walking belongs inside the guard
wraithgar
force-pushed
the
gar/more-symbols
branch
from
00c24d3 to
c5a14ad
Compare
wraithgar
pushed a commit
that referenced
this pull request
Mar 4, 2026
This contains the changes from - a2154cd (#8996) - 880ecb7 (#9013) - 26fa40e (#9041) - 983742b (#9055) - 10d5302 (#9051) - a29aeee (#9028) - 16fbe13 (#9030) - 8614b2a (#9031) Since Node 22 doesn't have npm 11 yet, it would be better to have this change backported to v10 Also, we wish to use `install-strategy=linked` in the [Gutenberg monorepo](WordPress/gutenberg#75814), which powers the WordPress Block Editor. We are still on v10. So, these fixes will help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a removal of the Symbols left in isolated reifier and ended as a bit of a cleanup/refactor.
Inline functions were moved to either static ones or class functions, forEach was changes to for loops where possible, comments were unwrapped, and more.