You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
manzoorwanijk
changed the title
fix/linked strategy/backport omit dev and workspace hoisting
fix(arborist): backport linked strategy fixes to v10
Mar 9, 2026
manzoorwanijk
changed the title
fix(arborist): backport linked strategy fixes to v10
fix(arborist): backport linked strategy hoisting fixes to v10
Mar 9, 2026
This is a hairy one. Normally I'd say this should go on the node itself but can see why we would want it to be inversed (pass in the node and have the omits as context instead) so that we minimize how much we have to backport.
We're getting into quite a bit of divergence from the main branch and this is going to start to become harder and harder to maintain as time goes on.
This is a hairy one. Normally I'd say this should go on the node itself but can see why we would want it to be inversed (pass in the node and have the omits as context instead) so that we minimize how much we have to backport.
We're getting into quite a bit of divergence from the main branch and this is going to start to become harder and harder to maintain as time goes on.
Should we move shouldOmit to the Node class and update the tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of:
Additional changes:
shouldOmitmethod to v10'sNodeclass (exists onlatestbut was missing on v10) with full test coverageReferences