Skip to content

fix(arborist): backport linked strategy hoisting fixes to v10#9084

Merged
wraithgar merged 5 commits intonpm:release/v10from
manzoorwanijk:fix/linked-strategy/backport-omit-dev-and-workspace-hoisting
Mar 9, 2026
Merged

fix(arborist): backport linked strategy hoisting fixes to v10#9084
wraithgar merged 5 commits intonpm:release/v10from
manzoorwanijk:fix/linked-strategy/backport-omit-dev-and-workspace-hoisting

Conversation

@manzoorwanijk
Copy link
Contributor

@manzoorwanijk manzoorwanijk commented Mar 9, 2026

Cherry pick of:

Additional changes:

  • Ported shouldOmit method to v10's Node class (exists on latest but was missing on v10) with full test coverage

References

@manzoorwanijk manzoorwanijk requested a review from a team as a code owner March 9, 2026 17:25
@manzoorwanijk manzoorwanijk changed the title fix/linked strategy/backport omit dev and workspace hoisting fix(arborist): backport linked strategy fixes to v10 Mar 9, 2026
@manzoorwanijk manzoorwanijk changed the title fix(arborist): backport linked strategy fixes to v10 fix(arborist): backport linked strategy hoisting fixes to v10 Mar 9, 2026
@manzoorwanijk
Copy link
Contributor Author

CC @wraithgar

@wraithgar
Copy link
Member

This is a hairy one. Normally I'd say this should go on the node itself but can see why we would want it to be inversed (pass in the node and have the omits as context instead) so that we minimize how much we have to backport.

We're getting into quite a bit of divergence from the main branch and this is going to start to become harder and harder to maintain as time goes on.

@manzoorwanijk
Copy link
Contributor Author

This is a hairy one. Normally I'd say this should go on the node itself but can see why we would want it to be inversed (pass in the node and have the omits as context instead) so that we minimize how much we have to backport.

We're getting into quite a bit of divergence from the main branch and this is going to start to become harder and harder to maintain as time goes on.

Should we move shouldOmit to the Node class and update the tests?

@manzoorwanijk
Copy link
Contributor Author

Moved shouldOmit to the Node class itself to match latest, keeping the same API surface on both branches should make future backports easier.

@wraithgar wraithgar merged commit ebd09c3 into npm:release/v10 Mar 9, 2026
20 checks passed
@manzoorwanijk manzoorwanijk deleted the fix/linked-strategy/backport-omit-dev-and-workspace-hoisting branch March 9, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants