Skip to content

fix(arborist): simplify rootDeclaredDeps initialization #9097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wraithgar merged 1 commit into from
Mar 10, 2026
Merged

fix(arborist): simplify rootDeclaredDeps initialization #9097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions workspaces/arborist/lib/arborist/isolated-reifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ module.exports = cls => class IsolatedReifier extends cls {
// For isolated/linked mode, only include workspaces that root explicitly declares as dependencies.
// When omitting dep types, exclude those from the declared set so their workspaces aren't hoisted.
const rootPkg = idealTree.package
this.#rootDeclaredDeps = new Set([
...Object.keys(rootPkg.dependencies || {}),
...(!omit.has('dev') ? Object.keys(rootPkg.devDependencies || {}) : []),
...(!omit.has('optional') ? Object.keys(rootPkg.optionalDependencies || {}) : []),
...(!omit.has('peer') ? Object.keys(rootPkg.peerDependencies || {}) : []),
])
this.#rootDeclaredDeps = new Set(Object.keys(Object.assign({},
rootPkg.dependencies,
(!omit.has('dev') && rootPkg.devDependencies),
(!omit.has('optional') && rootPkg.optionalDependencies),
(!omit.has('peer') && rootPkg.peerDependencies)
)))

// XXX this sometimes acts like a node too
this.idealGraph = {
Expand Down
Loading