Conversation
Member
|
I'm sorry for the confusion. I was asking for this to be in a single PR with two commits. I know it's more than we usually ask of external contributors. If you want, you can let us worry about it. Go ahead and make the single PR and we'll make a new one off of that in the form we need. Again, sorry for the extra work. |
Contributor
Author
|
Got it. No need to apologize. JS isn't my first language. I'm continuously learning about it and open source practices. 😃 Let's finish the review in #697 and then you can create the new PR as required. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lru-cachepackage is out-of-date (6.0.0) but would require a major to bring to latest due to node engine requirements.This removes the dependency on the
lru-cachepackage. It's replaced by a class in this package (#697).References
#695
npm/cli#7350