fix: fallback for missing process.env.ComSpec on Windows #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
issue No. #131
On Windows, some environments don’t expose process.env.ComSpec.
When that happens, the shell selection logic ends up passing undefined to child_process.spawn(), throwing ERR_INVALID_ARG_TYPE (“file” must be a string).
This PR updates the shell resolution so that on win32 we fallback to "cmd.exe" when process.env.ComSpec is missing, while preserving existing behavior on:
non-Windows (sh) and
Windows when ComSpec is set (still honored).
Rationale: cmd.exe is the standard Windows shell and is present by default. This change prevents crashes in real-world setups without altering behavior for users who explicitly define ComSpec.
Change summary
Update shell selection:
Add/adjust tests to cover the “missing ComSpec” case on Windows.
Tests
References
Prior attempt on npm/cli was closed with a maintainer note that this logic lives in @npmcli/promise-spawn (npm vendors this dependency).
GitHub