Skip to content

Comments

fix(ui): fix squashed avatars & add missing mobile bluesky avatar#1022

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
RYGRIT:fix/squashed-avatar
Feb 5, 2026
Merged

fix(ui): fix squashed avatars & add missing mobile bluesky avatar#1022
danielroe merged 1 commit intonpmx-dev:mainfrom
RYGRIT:fix/squashed-avatar

Conversation

@RYGRIT
Copy link
Contributor

@RYGRIT RYGRIT commented Feb 5, 2026

this pr:

  1. fixes: Squashed Atmoshphere avatar #999
  2. add missing mobile bluesky avatar

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 1:39pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 1:39pm
npmx-lunaria Ignored Ignored Feb 5, 2026 1:39pm

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Header/MobileMenu.client.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The pull request modifies avatar rendering in two header components by adding the object-cover CSS class to avatar image elements across AccountMenu.client.vue and MobileMenu.client.vue. Additionally, the MobileMenu component now includes conditional avatar rendering for atprotoUser, displaying an image element when an avatar exists and falling back to a placeholder with a cloud icon when unavailable. These changes apply consistently to both npm and Atmosphere avatar displays.

Possibly related PRs

  • feat: show bluesky avatar in header #896: Both pull requests directly modify avatar rendering in header components with focus on AccountMenu.client.vue and MobileMenu.client.vue, introducing conditional avatar display and styling enhancements.

Suggested reviewers

  • zeucapua
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly references the linked issue #999 and clearly identifies the two main objectives: fixing squashed avatars and adding a missing mobile Bluesky avatar.
Linked Issues check ✅ Passed The code changes successfully address issue #999 by adding object-cover CSS class to avatar elements, which prevents squashing and ensures proper aspect ratio preservation for the Atmosphere avatar.
Out of Scope Changes check ✅ Passed All changes are scoped to the stated objectives: adding object-cover to avatar elements to fix squashing (issue #999) and adding conditional avatar rendering with fallback placeholder for mobile Bluesky avatar support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit 7c88654 Feb 5, 2026
15 of 16 checks passed
@RYGRIT RYGRIT deleted the fix/squashed-avatar branch February 6, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Squashed Atmoshphere avatar

2 participants