Skip to content

Comments

feat: polish ui and ux on settings page#1026

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
alexdln:feat/polish-settings-page
Feb 5, 2026
Merged

feat: polish ui and ux on settings page#1026
danielroe merged 2 commits intonpmx-dev:mainfrom
alexdln:feat/polish-settings-page

Conversation

@alexdln
Copy link
Member

@alexdln alexdln commented Feb 5, 2026

Changes:

  • Added focus to radio fieldsets, since it was completely unclear where the cursor was at that moment
  • Changed the accent-color color of the "no color" option, as it was following the current accent-color, which looked strange
  • Added a focus effect to the "toggle" element for the toggle elements, as it looked bad across the entire page and the rounding didn't fit the toggle element
  • Added padding to the top and bottom of the toggle elements, as the height was only 24px
  • Changed settings markup, as managing indents within child component through its parent is bad practice
  • Added an invisible click zone to the back button and adjusted the text on mobile to be sr-only for the A11.
  • Added hover to toggle and select buttons.

Closes #1025

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 4:19pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 4:19pm
npmx-lunaria Ignored Ignored Feb 5, 2026 4:19pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

This pull request introduces UI/UX refinements to the settings page components. Changes include adding focus-visible styling to fieldset elements in colour and theme picker components, updating the Toggle component with a new class prop and extended styling for focus and hover states, and refactoring the main settings page with improved spacing, accessibility labels, and conditional hover effects across theme and language selectors. The modifications maintain existing functionality whilst enhancing visual hierarchy and keyboard navigation support.

Possibly related PRs

Suggested reviewers

  • danielroe
  • 43081j
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly details UI/UX improvements made to the settings page, directly corresponding to changes in the file summaries.
Linked Issues check ✅ Passed The changes address all stated objectives from issue #1025: focus styling for keyboard navigation, colour adjustments, toggle element improvements, accessibility enhancements, and hover states.
Out of Scope Changes check ✅ Passed All modifications are within the scope of polishing the settings page UI/UX as specified in issue #1025; no unrelated changes detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so beautiful 😍

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit a729534 Feb 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ui): polish settings page

2 participants