Skip to content

Comments

fix(i18n): rename az.json file to az-AZ.json#1043

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
userquin:rename-az-AZ-json-file
Feb 5, 2026
Merged

fix(i18n): rename az.json file to az-AZ.json#1043
danielroe merged 2 commits intonpmx-dev:mainfrom
userquin:rename-az-AZ-json-file

Conversation

@userquin
Copy link
Member

@userquin userquin commented Feb 5, 2026

I'm going to include some check at scrpts/compare-translations.ts to prevent this.

NOTE: to rename an exiting file:

  1. rename the file at i18n/locales updating config/i18n.ts (don't rename the file at lunaria/files)
  2. commit + push changes: await autofix workflow error here at GH, you will need to commit with --no-verify (if you're using some IDE like WebStorm, you will need to uncheck Run Git hooks)
  3. run pnpm build:lunaria from root in your local: old locale file at lunaria will be removed and created the new one at lunaria/files
  4. commit + push changes
image

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 9:30pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 9:30pm
npmx-lunaria Ignored Ignored Feb 5, 2026 9:30pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • lunaria/files/az-AZ.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
📝 Walkthrough

Walkthrough

The config/i18n.ts file was modified to update the locale configuration for the 'az' (Azerbaijani) language. The file reference was changed from 'az.json' to 'az-AZ.json', providing a more specific locale identifier that includes the country code. This change reflects a rename of the associated translation file path without modifying the underlying code structure or functionality.

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided by the author, making it impossible to assess whether the description relates to the changeset. The author should add a pull request description explaining the rationale for renaming the locale file from 'az.json' to 'az-AZ.json' and any related context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/az-AZ.json Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe enabled auto-merge February 5, 2026 21:44
@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit 2273d3b Feb 5, 2026
18 checks passed
@userquin userquin deleted the rename-az-AZ-json-file branch February 5, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants