Skip to content

Comments

fix: update link path in search-suggestion-card#1102

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
alexdln:fix/correct-to-pack-in-suggest-card
Feb 6, 2026
Merged

fix: update link path in search-suggestion-card#1102
danielroe merged 1 commit intonpmx-dev:mainfrom
alexdln:fix/correct-to-pack-in-suggest-card

Conversation

@alexdln
Copy link
Member

@alexdln alexdln commented Feb 6, 2026

The link on the search page in the recommendation card (matched user or organization) was broken. Essentially, it continued to lead to the old path, from which it hadn't been redirected.

The link simply got lost in the flurry of changes, so added a microfix with the new link format

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 4:03pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 4:03pm
npmx-lunaria Ignored Ignored Feb 6, 2026 4:03pm

Request Review

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The SearchSuggestionCard.vue component was updated to refactor the NuxtLink navigation routing approach. The to prop previously used string-based paths ("~name" for users and "/@name" for organisations) has been replaced with object-based route definitions using named routes. User routes now use the route name '~username' with username parameters, whilst organisation routes use the route name 'org' with org parameters. The component's other functionality and bindings remain unchanged.

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description is incomplete and provides no meaningful information about the changeset. Complete the pull request description to clearly explain the purpose and rationale for updating the NuxtLink route format in the SearchSuggestionCard component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
Merged via the queue into npmx-dev:main with commit c6db424 Feb 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants