Skip to content

Comments

chore: store return URLs in session#1117

Merged
43081j merged 2 commits intomainfrom
jg/miscellaneous-sketchiness
Feb 6, 2026
Merged

chore: store return URLs in session#1117
43081j merged 2 commits intomainfrom
jg/miscellaneous-sketchiness

Conversation

@43081j
Copy link
Contributor

@43081j 43081j commented Feb 6, 2026

Stores the return URL in the session rather than using cookies.

Stores the return URL in the session rather than using cookies.
@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 11:15pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 11:15pm
npmx-lunaria Ignored Ignored Feb 6, 2026 11:15pm

Request Review

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

This pull request introduces a new hashing dependency (ohash) and refactors authentication and caching mechanisms. The auth redirect target storage has been migrated from client-side cookies to server-side session storage by adding a returnTo property to the UserServerSession interface. Badge query parameters now employ stricter validation through SafeStringSchema, and cache key generation for badge endpoints has been updated to use hash functions instead of JSON serialisation. These changes improve security by moving sensitive redirect information server-side and enhance caching consistency.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly aligns with the changeset, which refactors auth redirect target storage from cookies to server sessions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jg/miscellaneous-sketchiness

Comment @coderabbitai help to get the list of available commands and usage tips.

@43081j 43081j enabled auto-merge February 6, 2026 23:16
@43081j 43081j added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 79a62fa Feb 6, 2026
21 checks passed
@43081j 43081j deleted the jg/miscellaneous-sketchiness branch February 6, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants