Skip to content

Comments

fix: opening package docs in a new tab doesn't work#1145

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
NandkishorJadoun:fix/package-docs-404
Feb 7, 2026
Merged

fix: opening package docs in a new tab doesn't work#1145
danielroe merged 1 commit intonpmx-dev:mainfrom
NandkishorJadoun:fix/package-docs-404

Conversation

@NandkishorJadoun
Copy link
Contributor

@NandkishorJadoun NandkishorJadoun commented Feb 7, 2026

closes #1101

Description

simplified the package-docs route rules in nuxt.config to use a global glob pattern. This fixes an issue where Vercel ISR would incorrectly map path parameters, causing 404s and malformed URLs ([...]) when opening documentation in a new tab.

@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 7, 2026 11:24am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 7, 2026 11:24am
npmx-lunaria Ignored Ignored Feb 7, 2026 11:24am

Request Review

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@NandkishorJadoun NandkishorJadoun marked this pull request as ready for review February 7, 2026 11:39
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

This change modifies the Nuxt configuration to consolidate package documentation routes. Two separate versioned routes for package docs (/package-docs/:name/v/** and /package-docs/:org/:name/v/**) are replaced with a single wildcard route (/package-docs/**). The incremental static regeneration (ISR) setting and cache duration (365 days) remain unchanged. This route consolidation addresses routing resolution issues when opening package documentation links in new browser tabs.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the route simplification and the specific issue (Vercel ISR routing conflict) being resolved.
Linked Issues check ✅ Passed The changes address issue #1101 by simplifying the package-docs route rules to use a glob pattern, which resolves the ISR path parameter mapping issue causing 404s.
Out of Scope Changes check ✅ Passed The changes are limited to the nuxt.config.ts file, consolidating two specific routes into a single wildcard route, which is directly scoped to the stated objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 7, 2026
Merged via the queue into npmx-dev:main with commit d4060bd Feb 7, 2026
19 checks passed
@NandkishorJadoun NandkishorJadoun deleted the fix/package-docs-404 branch February 10, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening package docs in a new tab doesn't work

2 participants