Skip to content

Comments

feat(i18n): update Chinese translations for privacy page and missing …#1196

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
penjj:main
Feb 8, 2026
Merged

feat(i18n): update Chinese translations for privacy page and missing …#1196
danielroe merged 2 commits intonpmx-dev:mainfrom
penjj:main

Conversation

@penjj
Copy link
Contributor

@penjj penjj commented Feb 8, 2026

Add missing Chinese (zh-CN) translations for:

  1. Privacy policy page (complete)
  2. Package size formatting
  3. Downloads legend estimation
  4. Compare page total likes facet

89 insertions, 3 modifications across the zh-CN locale file.

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 6:30am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 8, 2026 6:30am
npmx-lunaria Ignored Ignored Feb 8, 2026 6:30am

Request Review

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Building Building Preview, Comment Feb 8, 2026 6:27am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

This pull request adds new translation keys to the Chinese (Simplified) locale file. Changes include introducing three new keys under the downloads section: legend_estimation and size with sub-keys for bytes/kilobytes/megabytes, plus a totalLikes key under facets. The privacy policy section receives substantial expansion with new subsections covering welcome information, cookies, local storage, management instructions, analytics, authenticated data, data retention, user rights, contact information, and policy changes. All modifications are localization additions with no changes to executable code logic.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately summarises the changeset, detailing the addition of Chinese translations for privacy policy, package sizes, downloads legend, and likes facet.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 8, 2026
Merged via the queue into npmx-dev:main with commit bf3df3e Feb 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants