fix: add strategy to tooltip and use it in sticky elems#1330
fix: add strategy to tooltip and use it in sticky elems#1330danielroe merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request introduces configurable tooltip positioning strategy across the application. The Tooltip Base component receives a new optional Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
The tooltips moved smoothly, even though their trigger remained in place (sticky package header). This looked odd. Floating UI supports this feature out of the box, so I configured it as prop for
Tooltipand used it in the places I foundI didn't add any new tests, as it's a third-party library' logic
Closes #1251