Skip to content

Comments

feat: compare page search package add esc keyboard event#1333

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
btea:feat/compare-page-search-package-add-escape-event
Feb 10, 2026
Merged

feat: compare page search package add esc keyboard event#1333
danielroe merged 1 commit intonpmx-dev:mainfrom
btea:feat/compare-page-search-package-add-escape-event

Conversation

@btea
Copy link
Contributor

@btea btea commented Feb 10, 2026

Bind an Esc keyboard event to the input field to quickly cancel or delete typed content.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 0:58am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 0:58am
npmx-lunaria Ignored Ignored Feb 10, 2026 0:58am

Request Review

@danielroe danielroe enabled auto-merge February 10, 2026 12:58
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

The PackageSelector.vue component has been modified to handle the Escape key in the input field. When Escape is pressed, the input value is cleared. The existing Enter key functionality remains unchanged, continuing to add a selected or no-dependency option or match a package. The change adds 2 lines of code with no removals.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset: binding an Escape key event to clear input in the PackageSelector component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Compare/PackageSelector.vue 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit dc038d1 Feb 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants