fix: only show estimation segment in last datapoint#1338
fix: only show estimation segment in last datapoint#1338graphieros merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe TrendsChart component has been refactored to simplify its approach to handling estimations for incomplete data periods. A new Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip We've launched Issue Planner and it is currently in beta. Please try it out and share your feedback on Discord! Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/components/Package/TrendsChart.vue (1)
1346-1350: Update the stale inline comment onuseNiceScale.
The note still says monthly/yearly → false, but the flag is now alwaystrue, which is misleading.Proposed fix
- useNiceScale: true, // daily/weekly -> true, monthly/yearly -> false + useNiceScale: true,
|
Looks amazing! at least from a functionality POV |
closes #1318