Skip to content

fix: overlapping watermark with rotated labels #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Feb 11, 2026
Merged

fix: overlapping watermark with rotated labels #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/components/Package/VersionDistribution.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const chartConfig = computed(() => {
padding: {
top: 24,
right: 24,
bottom: xAxisLabels.value.length > 10 ? 100 : 88, // Space for rotated labels + watermark
bottom: xAxisLabels.value.length > 10 ? 84 : 72, // Space for rotated labels + watermark
left: isMobile.value ? 60 : 80,
},
userOptions: {
Expand Down Expand Up @@ -429,9 +429,7 @@ const endDate = computed(() => {
<!-- Inject npmx logo & tagline during SVG and PNG print -->
<g
v-if="svg.isPrintingSvg || svg.isPrintingImg"
v-html="
drawNpmxLogoAndTaglineWatermark(svg, watermarkColors, $t, 'belowDrawingArea')
"
v-html="drawNpmxLogoAndTaglineWatermark(svg, watermarkColors, $t, 'bottom')"
/>
</template>

Expand Down
2 changes: 1 addition & 1 deletion app/composables/useChartWatermark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function drawNpmxLogoAndTaglineWatermark(
// Position watermark based on the positioning strategy
const watermarkY =
positioning === 'belowDrawingArea'
? svg.drawingArea.top + svg.drawingArea.height + 48
? svg.drawingArea.top + svg.drawingArea.height + 58
: svg.height - npmxLogoHeight

const taglineY =
Expand Down
Loading