Skip to content

feat: ctrl+k to focus search #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ls-root wants to merge 1 commit into from
Closed

feat: ctrl+k to focus search #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions app/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,22 +47,36 @@ if (import.meta.server) {
setJsonLd(createWebSiteSchema())
}

function focusSearchOrNavigate() {
const searchInput = document.querySelector<HTMLInputElement>(
'input[type="search"], input[name="q"]',
)

if (searchInput) {
searchInput.focus()
return
}

router.push({ name: 'search' })
}

onKeyDown(
'/',
e => {
if (isEditableElement(e.target)) return
e.preventDefault()
focusSearchOrNavigate()
},
{ dedupe: true },
)

const searchInput = document.querySelector<HTMLInputElement>(
'input[type="search"], input[name="q"]',
)

if (searchInput) {
searchInput.focus()
return
}

router.push({ name: 'search' })
onKeyDown(
// Explicitly check Ctrl+K for broader compatibility (especially Firefox)
e => e.ctrlKey && e.key === 'k',
e => {
if (isEditableElement(e.target)) return
e.preventDefault()
focusSearchOrNavigate()
},
{ dedupe: true },
)
Expand Down
4 changes: 4 additions & 0 deletions app/components/AppFooter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ const showModal = () => modalRef.value?.showModal?.()
<kbd class="kbd">/</kbd>
<span>{{ $t('shortcuts.focus_search') }}</span>
</li>
<li class="flex gap-2 items-center">
<kbd class="kbd">Ctrl</kbd>+<kbd class="kbd">K</kbd>
<span>{{ $t('shortcuts.focus_search') }}</span>
</li>
<li class="flex gap-2 items-center">
<kbd class="kbd">?</kbd>
<span>{{ $t('shortcuts.show_kbd_hints') }}</span>
Expand Down
Loading