Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This adds a replacements notice to the dependency list just like outdated, vulnerable, etc. Each dependency with community replacements shows an amber warning and tooltip.
a3f7b81 to
759f831
Compare
📝 WalkthroughWalkthroughAdds dependency replacement suggestions: a new client-only composable Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/components/Package/Dependencies.vue (1)
130-171:⚠️ Potential issue | 🟡 MinorAdd SR‑only text for the replacement indicator.
Screen readers currently won’t get the “has replacement” message, unlike outdated/vulnerable indicators. Add an SR‑only hint so the new indicator is accessible.
♿ Suggested fix
<TooltipApp v-if="replacementDeps[dep]" class="shrink-0 p-2 -m-2 text-amber-700 dark:text-amber-500" aria-hidden="true" :text="$t('package.dependencies.has_replacement')" > <span class="i-carbon:idea w-3 h-3" /> </TooltipApp> + <span v-if="replacementDeps[dep]" class="sr-only"> + ({{ $t('package.dependencies.has_replacement') }}) + </span>
This adds a replacements notice to the dependency list just like outdated,
vulnerable, etc.
Each dependency with community replacements shows an amber warning and
tooltip.