Skip to content

Comments

feat: switch dependency icons to be tappable tooltips#1471

Merged
ghostdevv merged 1 commit intomainfrom
jg/fixeroos-in-the-last-hours-before-patak-goes-skiing
Feb 13, 2026
Merged

feat: switch dependency icons to be tappable tooltips#1471
ghostdevv merged 1 commit intomainfrom
jg/fixeroos-in-the-last-hours-before-patak-goes-skiing

Conversation

@43081j
Copy link
Contributor

@43081j 43081j commented Feb 13, 2026

This changes the icons to be their own tappable (or clickable) icons
which then open their tooltips.

Before this change, there was no way to see them on mobile as a tap
would click the version link and change page.

This changes the icons to be their own tappable (or clickable) icons
which then open their tooltips.

Before this change, there was no way to see them on mobile as a tap
would click the version link and change page.
@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 5:04pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 5:04pm
npmx-lunaria Ignored Ignored Feb 13, 2026 5:04pm

Request Review

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/Dependencies.vue 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the Dependencies.vue component to refactor how dependency status indicators and their associated tooltips are implemented. The changes replace span wrappers with button elements for outdated and replacement dependency indicators. The circle-alert icon for outdated dependencies and the lightbulb icon for replacement suggestions are now wrapped in buttons with explicit aria-labels. The modifications remove inline padding classes and the aria-hidden attribute from the tooltip targets, simplifying the visual wrapper structure whilst maintaining the functional tooltip behaviour.

Possibly related PRs

  • fix: show info-tooltips on mobile #1268: Modifies the same tooltip and indicator wrapper implementation in the Dependencies.vue component with related refactoring to icon-trigger and tooltip structure.

Suggested reviewers

  • danielroe
  • knowler
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset by explaining the problem (icons not tappable on mobile) and the solution (making icons their own tappable elements with tooltips).
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jg/fixeroos-in-the-last-hours-before-patak-goes-skiing

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv ghostdevv added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 1e45cdc Feb 13, 2026
20 checks passed
@ghostdevv ghostdevv deleted the jg/fixeroos-in-the-last-hours-before-patak-goes-skiing branch February 13, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants