Skip to content

Comments

chore: add "v" before version number on badges#1488

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:v
Feb 14, 2026
Merged

chore: add "v" before version number on badges#1488
ghostdevv merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:v

Conversation

@wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Feb 14, 2026

In other places, we show package version number with "v" prefix, which also helps recognizing what number we're actually looking at if we override label:

nuxt

It's also in line with shields.io style:

Copilot AI review requested due to automatic review settings February 14, 2026 00:24
@vercel
Copy link

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 14, 2026 0:45am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 14, 2026 0:45am
npmx-lunaria Ignored Ignored Feb 14, 2026 0:45am

Request Review

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a "v" prefix to version numbers displayed in package badges (e.g., "1.0.0" becomes "v1.0.0"), aligning with common conventions used by shields.io and throughout the codebase where versions are displayed with the "v" prefix.

Changes:

  • Modified the version badge strategy to prepend "v" to the version number

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

Warning

Rate limit exceeded

@wojtekmaj has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

A modification to the version badge strategy in the API registry endpoint updates the displayed badge text format. The version value is now prefixed with a "v" character when rendered on the badge. The underlying version retrieval mechanism—including fallback to latest version and handling of unknown versions—remains unchanged. The modification affects only the final output string presentation, with two lines added and two lines removed in the affected file.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (14 files):

⚔️ app/components/Org/OperationsQueue.vue (content)
⚔️ app/components/Package/ClaimPackageModal.vue (content)
⚔️ app/components/Package/TrendsChart.vue (content)
⚔️ app/components/Package/Versions.vue (content)
⚔️ app/components/Package/WeeklyDownloadStats.vue (content)
⚔️ app/components/Readme.vue (content)
⚔️ app/composables/useCharts.ts (content)
⚔️ app/pages/compare.vue (content)
⚔️ app/pages/package/[[org]]/[name].vue (content)
⚔️ i18n/locales/en.json (content)
⚔️ i18n/schema.json (content)
⚔️ lunaria/files/en-GB.json (content)
⚔️ lunaria/files/en-US.json (content)
⚔️ modules/runtime/server/cache.ts (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly explains the change: adding 'v' prefix to version numbers on badges for consistency with other parts of the project and shields.io style.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@wojtekmaj wojtekmaj force-pushed the v branch 2 times, most recently from 00a8487 to e075b05 Compare February 14, 2026 00:41
In other places, we show package version number with "v" prefix, which also helps recognizing what number we're actually looking at.
@ghostdevv ghostdevv added this pull request to the merge queue Feb 14, 2026
Merged via the queue into npmx-dev:main with commit aa18b6f Feb 14, 2026
17 checks passed
@wojtekmaj wojtekmaj deleted the v branch February 14, 2026 07:08
alex-key pushed a commit to alex-key/npmx.dev that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants