fix(ui): use correct icon name for table header sort icon#1551
fix(ui): use correct icon name for table header sort icon#1551danielroe merged 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis pull request updates the visual indicator icon used for sortable columns in the Package Table component. The icon class has been changed from Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
follow up for #1454
I found this via a warning message during the build.
I think those are the only remaining ones. I also double-checked the other icons by the global search and icon preview feature in my editor. 🙂
Maybe we could make it error instead of warning like this? https://github.com/npmx-dev/npmx.dev/blob/eb19ccdd8dee4cd5ee2033f902e36ae0ab69a55a/scripts/unocss-checker.ts
Screenshot (after fix)