Skip to content

Comments

fix(ui): use correct icon name for table header sort icon#1551

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:fix/recover-disappered-icon
Feb 22, 2026
Merged

fix(ui): use correct icon name for table header sort icon#1551
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:fix/recover-disappered-icon

Conversation

@shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 21, 2026

follow up for #1454

I found this via a warning message during the build.

I think those are the only remaining ones. I also double-checked the other icons by the global search and icon preview feature in my editor. 🙂

> pnpm build
 WARN  Unsupported engine: wanted: {"node":"24"} (current: {"node":"v25.5.0","pnpm":"10.28.2"})

> npmx@0.0.0 build /home/shuuji3/dev/npmx.dev
> nuxt build

┌  Building Nuxt for production...
│
●  Nuxt 4.3.1 (with Nitro 2.13.1, Vite 7.3.1 and Vue 3.5.28)
ℹ Using html-validate to validate server-rendered HTML                                                                                                                                                              5:44:39 PM

 WARN  [standard-site-sync] NPMX_PDS_URL not set, skipping sync                                                                                                                                                      5:44:39 PM

│
●  Nitro preset: node-server
ℹ vite v8.0.0-beta.11 building client environment for production...                                                                                                                                                 5:44:40 PM
✓ 882 modules transformed.
[unocss] failed to load icon "lucide:caret-down"
...

Maybe we could make it error instead of warning like this? https://github.com/npmx-dev/npmx.dev/blob/eb19ccdd8dee4cd5ee2033f902e36ae0ab69a55a/scripts/unocss-checker.ts

Screenshot (after fix)

Screenshot from 2026-02-21 17-41-37

@vercel
Copy link

vercel bot commented Feb 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Feb 22, 2026 8:08am
npmx.dev Ready Ready Preview, Comment Feb 22, 2026 8:08am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 22, 2026 8:08am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request updates the visual indicator icon used for sortable columns in the Package Table component. The icon class has been changed from i-lucide:caret-down to i-lucide:chevron-down for the downloads and updated columns. The underlying rotation and visibility logic for the icon remains unchanged. The change affects two lines of code with no modifications to public APIs or exported declarations.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is directly related to the changeset, explaining that an icon class was changed from caret-down to chevron-down to fix a build warning about unsupported icons.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe changed the title fix: recover disappeared table header icon for sorting fix(ui): use correct icon name for table header sort icon Feb 22, 2026
@danielroe danielroe added this pull request to the merge queue Feb 22, 2026
Merged via the queue into npmx-dev:main with commit f9fca21 Feb 22, 2026
18 checks passed
@shuuji3 shuuji3 deleted the fix/recover-disappered-icon branch February 22, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants