Skip to content

Comments

fix: improve versions modal input alignment#1553

Open
iiio2 wants to merge 5 commits intonpmx-dev:mainfrom
iiio2:fix/improve-version-modal-input-alignment
Open

fix: improve versions modal input alignment#1553
iiio2 wants to merge 5 commits intonpmx-dev:mainfrom
iiio2:fix/improve-version-modal-input-alignment

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 21, 2026

Before:
before

After:
after

@vercel
Copy link

vercel bot commented Feb 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 23, 2026 2:32am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 23, 2026 2:32am
npmx-lunaria Ignored Ignored Feb 23, 2026 2:32am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request modifies the VersionDistribution.vue component with two main categories of changes. First, it adjusts the UI layout and styling by changing container alignment from sm:items-end to sm:items-start, increasing border radius from rounded-md to rounded-lg, and increasing button vertical padding from py-1.75 to py-4. Second, it introduces keyboard accessibility to the grouping toggle functionality by adding a handleGroupingKeydown event handler that enables users to switch between major and minor grouping modes via Enter, Space, ArrowLeft, and ArrowRight keys. The changes also add ARIA attributes and disabled state bindings to the toggle buttons.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description includes visual before/after screenshots that directly relate to the UI changes documented in the changeset summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/VersionDistribution.vue 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants