Skip to content

Comments

fix: bump vue-data-ui and impacts#1568

Merged
graphieros merged 9 commits intonpmx-dev:mainfrom
graphieros:main
Feb 22, 2026
Merged

fix: bump vue-data-ui and impacts#1568
graphieros merged 9 commits intonpmx-dev:mainfrom
graphieros:main

Conversation

@graphieros
Copy link
Contributor

@graphieros graphieros commented Feb 22, 2026

  • Bump vue-data-ui from 3.15.0 to 3.15.5

Impacts

Downloads chart in modal

  • apply subtle path gradient
  • refactor (dry)
    Note: gradient paths are not used in the charts on the compare page

Versions chart (bars)

  • replace unnecessary use of the #area-gradient by #bar-gradient, with a subtle gradient based on the series color

Weekly downloads sparkline

  • Improve performance of the pulse trail (showing 1/3 of trailing circles compared to previous version). The value is increased from 20 to 30, but will only animate 10 dom nodes instead of 20 in the previous version.

@vercel
Copy link

vercel bot commented Feb 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 22, 2026 10:33am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 22, 2026 10:33am
npmx-lunaria Ignored Ignored Feb 22, 2026 10:33am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Consolidated dataset construction in TrendsChart.vue by introducing a shared datasetItem (name, type, series, color, temperatureColors, useArea) and computing a light color variant for dark mode; reused across weekly, daily, monthly and yearly branches. Tooltip guards in TrendsChart.vue and VersionDistribution.vue now return early when datapoint is missing or when a loading/pending state is active. VersionDistribution.vue replaces area-gradient with a bar-gradient, computing gradient stops using lightenHex and stop-opacity adjustments. WeeklyDownloadStats.vue increases the sparkline pulse trail length from 20 to 30. vue-data-ui bumped from 3.15.0 to 3.15.5.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • danielroe
  • shuuji3
  • whitep4nth3r
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately relates to and describes the changeset, including dependency bump and specific visual/performance improvements across three chart components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/VersionDistribution.vue 0.00% 1 Missing and 1 partial ⚠️
app/components/Package/TrendsChart.vue 80.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@graphieros graphieros enabled auto-merge February 22, 2026 10:08
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
app/components/Package/TrendsChart.vue (1)

204-220: Simplify redundant conditions in temperatureColors and use baseColor for the color field.

Three minor redundancies in this block:

  1. baseColor (Line 205) is always truthy — accent.value always yields a non-empty string via the OKLCH_NEUTRAL_FALLBACK fallback, so the && baseColor guard is a no-op.
  2. isDarkMode.value && typeof baseColor === 'string' (Lines 208–210) — typeof baseColor === 'string' is always true (the value is statically typed as string), and isDarkMode.value is redundant because lightColor is already undefined when not in dark mode, making typeof lightColor === 'string' sufficient alone.
  3. color: accent.value (Line 217) duplicates baseColor which already holds the same value.
♻️ Proposed simplification
- const lightColor = isDarkMode.value && baseColor ? lightenOklch(baseColor, 0.618) : undefined
+ const lightColor = isDarkMode.value ? lightenOklch(baseColor, 0.618) : undefined

- // Subtle path gradient applied in dark mode only
- const temperatureColors =
-   isDarkMode.value && typeof baseColor === 'string' && typeof lightColor === 'string'
-     ? [lightColor, baseColor]
-     : undefined
+ // Subtle path gradient applied in dark mode only
+ const temperatureColors = lightColor ? [lightColor, baseColor] : undefined

  const datasetItem: VueUiXyDatasetItem = {
    name: seriesName,
    type: 'line',
    series: dataset.map(d => d.value),
-   color: accent.value,
+   color: baseColor,
    temperatureColors,
    useArea: true,
  }

@graphieros graphieros added this pull request to the merge queue Feb 22, 2026
Merged via the queue into npmx-dev:main with commit bf2b20b Feb 22, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants